Implement optional backends for python-jose as setup.py extras.#57
Merged
mpdavis merged 1 commit intompdavis:masterfrom Jan 16, 2018
Merged
Implement optional backends for python-jose as setup.py extras.#57mpdavis merged 1 commit intompdavis:masterfrom
mpdavis merged 1 commit intompdavis:masterfrom
Conversation
…allows installing running pip install python-jose[cryptography] to install with cryptography. Supported backends libraries are cryptography, pycrypto and cryptodome.
Owner
|
I like this approach much better. Just a couple of issues:
I will be cutting a 2.0.0 after this lands to try to affect as few people as possible. |
Collaborator
Author
|
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
- Coverage 95.64% 95.51% -0.14%
==========================================
Files 12 12
Lines 734 735 +1
==========================================
Hits 702 702
- Misses 32 33 +1
Continue to review full report at Codecov.
|
This was referenced Jan 16, 2018
a23ef13 to
1c7691b
Compare
This was referenced Jan 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows installing running
pip install python-jose[cryptography]to install with cryptography. Supported backends libraries are cryptography, pycrypto and cryptodome.