Implement pure python rsa signing based on rsa module#58
Implement pure python rsa signing based on rsa module#58mpdavis merged 16 commits intompdavis:masterfrom
Conversation
…es. Cryptography may still require extra libraries.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 93.69% 93.62% -0.08%
==========================================
Files 12 13 +1
Lines 841 1004 +163
==========================================
+ Hits 788 940 +152
- Misses 53 64 +11
Continue to review full report at Codecov.
|
|
I need to go over this with a finer comb, but I wanted to let you know that I agree with the general idea here. |
|
My apologies, but #52 caused some conflicts with the tests due to a change to parameterize those tests, which should avoid some copy-paste for you. Additionally, it added the ability to export keys to JWKs which will need to be implemented on the new RSA key. |
|
Sure, will try to give some more attention to this in a timely manner. |
conform to standard and tests.
f993fa8 to
402c815
Compare
|
I've updated this pull request to finally implement RSA using pure Python package "rsa". |
|
I finally took a look at this, and everything looks good to me. |
This offers a fallback and ensures the library is usable even when a supported fast C implementation isn't available.