Add custom headers support to jwt.encode#7
Merged
mpdavis merged 3 commits intompdavis:masterfrom Nov 11, 2015
Merged
Conversation
tests/test_jwt.py
Outdated
Owner
There was a problem hiding this comment.
Python 2.6 doesn't support dict comprehension so you will probably have to do this the longer way. Something like this should work.
for k, v in headers.items():
assert all_headers[k] == v
Owner
|
Looks good. Thanks for the contribution. |
mpdavis
pushed a commit
that referenced
this pull request
Nov 11, 2015
Add custom headers support to jwt.encode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs for jwt.encode suggest that it supports custom headers, but the headers argument wasn't present.