Closed
Conversation
added 5 commits
February 9, 2018 13:54
Construct headers from an ordered dictionary instead a standard dict. This makes it possible not to send the headers in the token and rebuild them on the server side when it is used by client. Indeed, for this the json must be predictable. What do not allow std python dictionaries.
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 12 12
Lines 841 841
=======================================
Hits 788 788
Misses 53 53
Continue to review full report at Codecov.
|
|
Hi. What's the current status of this MR? Can it be merged? |
Collaborator
|
Implemented this via #136. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80
Construct headers from an ordered dictionary instead a standard dict.
This makes it possible not to send the headers in the token and rebuild
them on the server side when it is used by client. Indeed, for this the
json must be predictable. What do not allow std python dictionaries.