Move away from deprecated methods#85
Merged
mpdavis merged 1 commit intompdavis:masterfrom May 4, 2018
OnBeep:backend-crypto-verifier
Merged
Move away from deprecated methods#85mpdavis merged 1 commit intompdavis:masterfrom OnBeep:backend-crypto-verifier
mpdavis merged 1 commit intompdavis:masterfrom
OnBeep:backend-crypto-verifier
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 93.69% 93.65% -0.05%
==========================================
Files 12 12
Lines 841 835 -6
==========================================
- Hits 788 782 -6
Misses 53 53
Continue to review full report at Codecov.
|
Collaborator
|
Looks good to me. /cc @mpdavis |
Owner
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that running the project unit test in
pytest, I was getting some of the following Warnings:This PR moves from
verifier->verifyandsigner->sign.I would love a decent review of this code, just to double check that I didn't borken anything.