Skip to content

Allow using secret of type "bytes"#93

Closed
beebeeep wants to merge 1 commit intompdavis:masterfrom
beebeeep:allow-bytes-secret
Closed

Allow using secret of type "bytes"#93
beebeeep wants to merge 1 commit intompdavis:masterfrom
beebeeep:allow-bytes-secret

Conversation

@beebeeep
Copy link
Contributor

So far library assumes that secrets are strings which leads to certain complications in python3, namely it is impossible to use random binary vectors as secret as python3 string should be valid in terms of specified text encoding. Also constructions like 'keys' in key may lead to some unexpected behaviour if secret contains substring "keys". This changes makes key parsing logic a bit clearer and allows to use bytes strings secrets.

Also I believe that would resolve #74 and #72

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files          13       13           
  Lines         998      998           
=======================================
  Hits          934      934           
  Misses         64       64
Impacted Files Coverage Δ
jose/jws.py 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b6556...0b63471. Read the comment docs.

@beebeeep
Copy link
Contributor Author

beebeeep commented Jun 1, 2018

Anyone?

@blag
Copy link
Contributor

blag commented Dec 16, 2019

I'd be interested in merging this if you can add tests.

@blag blag mentioned this pull request Sep 7, 2020
@blag blag closed this in #187 Sep 7, 2020
@blag
Copy link
Contributor

blag commented Sep 7, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

base64url_decode TypeError: must be str, not bytes

3 participants