Open
Conversation
mphoward
requested changes
Jun 5, 2024
Collaborator
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks, this is going well too! Can you please take care of the small comments here, and then I can help you with the CMake setup for compiling these so you can also work on the GPU code.
| /*! | ||
| * \param noiseless If true, do not apply a random diffusive force | ||
| */ | ||
| void setNoiseless(bool noiseless) |
Collaborator
There was a problem hiding this comment.
This setter should not have been removed, please restore.
src/TwoStepBrownianFlow.h
Outdated
Comment on lines
+176
to
+177
| .def("getFlowField", &BrownianFlow::getFlowField) | ||
| .def("getNoiseless", &BrownianFlow::getNoiseless); |
Collaborator
There was a problem hiding this comment.
This is how you make a property. flow_field should be read-only, but noiseless can be mutable.
Suggested change
| .def("getFlowField", &BrownianFlow::getFlowField) | |
| .def("getNoiseless", &BrownianFlow::getNoiseless); | |
| .def_property_readonly("flow_field", &BrownianFlow::getFlowField) | |
| .def_property("noiseless", &BrownianFlow::getNoiseless, &BrownianFlow::setNoiseless); |
src/TwoStepBrownianFlow.h
Outdated
| } // end namespace detail | ||
| } // end namespace azplugins | ||
|
|
||
| } // end namespace hoomd |
Collaborator
There was a problem hiding this comment.
Suggested change
| } // end namespace hoomd | |
| } // end namespace hoomd | |
Collaborator
There was a problem hiding this comment.
Please apply the same changes to this file as for the BD one.
Collaborator
There was a problem hiding this comment.
I will help you write some machinery to compile these.
mayukh33
force-pushed
the
refactor/integrator
branch
from
eb25c1e to
4bdc2e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.