Conversation
…dvice or feedback before submitting a pull request. I also did not know the mathematical syntax for using an integral symbol so I just typed "integral" but if there is a way I can do that just let me know.
|
DMcCaleb1
changed the title
There was a problem hiding this comment.
Thank you! This is nice work, but there are a few parts that need to be changed. I've made an example change at the top, so please take a look and apply similar changes to the rest. Also, make sure to have the last line with ``` to properly close the example directive. Once you're done, please double-check for any typos and request a final review from Dr. Howard.
Co-authored-by: jinnyjc <157433652+jinnyjc@users.noreply.github.com>
|
I deleted the chevrons and ===='s, but I can't seem to separate the title of the example to be its own separate topic within variation of parameters, do you know how I could do that or separate them? I tried using ==== but it did not work. |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Here are some suggestions on the overall formatting! It's OK for the example not to show up as a separate numbered section. We are putting examples inside blue boxes so they stand out from the page.
Please fix the issues noted here, then also update the typesetting on the math that you haven't gotten to yet to make it look like the first half. Especially, make sure to use \alpha rather than the alpha character, and group multiple equations with {align}.
Please re-request another review when you're ready.
Co-authored-by: Michael Howard <mphoward@auburn.edu>
Co-authored-by: Michael Howard <mphoward@auburn.edu>
Co-authored-by: Michael Howard <mphoward@auburn.edu>
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thanks! I cleaned up some of the formatting on the integration by parts, but the last section still needs reformatting to make use of {align} and to make sure to use \alpha. Can you please update these and request another review? This should be good to merge at that point!
|
I implemented the use of {align} in the last section and made sure to use \alpha instead of the symbol itself, my apologies on that, as I overlooked it at first. Submitting another review request, please let me know if anything else sticks out. |
mphoward
left a comment
mphoward
left a comment
There was a problem hiding this comment.
Thank you! There were a couple small things, but I took care of these while I was reading through. Great job!
* I believe this reflects the pdf notes for issue 79, just wanted any advice or feedback before submitting a pull request. I also did not know the mathematical syntax for using an integral symbol so I just typed "integral" but if there is a way I can do that just let me know.
* Adding name to credits
* latex update
* update
* updating
* final update 4/22
* update 4/23
* Title update
* Update second-order-odes/variation-of-parameters.md
Co-authored-by: jinnyjc <157433652+jinnyjc@users.noreply.github.com>
* Updated
* Final update
* Final update 2
* New update
* original changes
* closing update
* reupdate, final change
* reupdate
* rechange
* title change
* new change
* removing typos
* revert changes
* title
* changing title
* reverting
* original
* erasing chevrons and ==
* renaming
* adding back variation of parameters
* Separating titles
* removing variation
* Trying to separate
* separation
* title
* Update second-order-odes/variation-of-parameters.md
Co-authored-by: Michael Howard <mphoward@auburn.edu>
* Update second-order-odes/variation-of-parameters.md
Co-authored-by: Michael Howard <mphoward@auburn.edu>
* Update second-order-odes/variation-of-parameters.md
Co-authored-by: Michael Howard <mphoward@auburn.edu>
* update 4/29
* Run pre-commit
* Clean up parts of example
* changing to alpha notation
* using {align}
* format fix
* format error fix
* Cleanup minor formatting
---------
Co-authored-by: Michael Howard <mphoward@auburn.edu>
Co-authored-by: jinnyjc <157433652+jinnyjc@users.noreply.github.com>
3 participants
New content
Resolves #79
Checklist
credits.md.