Skip to content

Integrating factor skill builder c#223

Merged
mphoward merged 13 commits intomainfrom
issue-99
May 9, 2025
Merged

Integrating factor skill builder c#223
mphoward merged 13 commits intomainfrom
issue-99

Conversation

@LaurenThompson11
Copy link
Contributor

@LaurenThompson11 LaurenThompson11 commented May 4, 2025 •
edited by mphoward
Loading

New content

Resolves #99

Checklist

  • New pages are added to the table of contents.
  • Everything displays correctly in the web-generated preview.
  • Appropriate attribution has been given to source materials.
  • My name is included alphabetically in credits.md.

LaurenThompson11
LaurenThompson11 commented May 5, 2025
View reviewed changes
Copy link
Contributor Author

@LaurenThompson11 LaurenThompson11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to get a preview link to see my code, just wanted to double check I am working on the correct section.

@mphoward
Copy link
Contributor

mphoward commented May 6, 2025

There was a merge conflict preventing this from building, I've fixed that for you!

@mphoward mphoward changed the title Problem c Integrating factor skill builder c May 6, 2025
mphoward
mphoward reviewed May 6, 2025
View reviewed changes
@mphoward
Copy link
Contributor

mphoward commented May 7, 2025

@LaurenThompson11 please make sure to finalize this and request a review from me ASAP to get credit for it!

LaurenThompson11
LaurenThompson11 commented May 7, 2025
View reviewed changes
Copy link
Contributor Author

@LaurenThompson11 LaurenThompson11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not getting a preview here, but I thought I got the problem directive from looking at other skill builders.

@mphoward
Copy link
Contributor

mphoward commented May 7, 2025

There is actually no {problem} directive, which is why I suggested to delete that. I will partially reformat this for you as soon as I can so it builds a preview.

@github-actions
Copy link

github-actions bot commented May 8, 2025 •
edited
Loading

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-09 02:35 UTC

mphoward
mphoward requested changes May 8, 2025
View reviewed changes
Copy link
Contributor

@mphoward mphoward left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed to build now! I moved an example from exact.md that I think might be better over here with integrating-factor.md. Can you please make your first problem (now 2.) look like the one I copied? Your second problem (now 3.) should be formatted to look like one of the two example solutions already here. Please re-request a review when this is done, thanks!

@LaurenThompson11 LaurenThompson11 requested a review from mphoward May 8, 2025 21:38
mphoward
mphoward approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mphoward mphoward merged commit 644a18f into main May 9, 2025
2 checks passed
@mphoward mphoward deleted the issue-99 branch May 9, 2025 02:35
mphoward added a commit that referenced this pull request May 9, 2025
@LaurenThompson11 @mphoward
Integrating factor skill builder c (#223)
868807b 
* Problem c

* update

* problem directive

* problem directive

* issue 99

* Problem 2

* Fix formatting, rearrange

* updated format

* updated

* Cleanup formatting

---------

Co-authored-by: Michael Howard <mphoward@auburn.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mphoward mphoward mphoward approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrating factor skill builders

2 participants

@LaurenThompson11 @mphoward