Skip to content

Fixes for Xml encoding of Matrix and Null encoding of Variants.#396

Merged
mregen merged 2 commits intomainfrom
fixxmlencoding
May 18, 2025
Merged

Fixes for Xml encoding of Matrix and Null encoding of Variants.#396
mregen merged 2 commits intomainfrom
fixxmlencoding

Conversation

@mregen
Copy link
Copy Markdown
Owner

@mregen mregen commented May 16, 2025

Ported from main repository

romanett and others added 2 commits May 15, 2025 13:57
… to spec (OPCFoundation#3053)

* Fix XML Encoding and decoding to conform to spec

* fix test on linux

* fix typo

* Add missing DataValue & DiagnosticInfo Array Types
@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (08aae6c) to head (dfc5953).

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/XmlDecoder.cs 83.87% 4 Missing and 1 partial ⚠️
Stack/Opc.Ua.Core/Types/Encoders/XmlEncoder.cs 68.75% 2 Missing and 3 partials ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/Variant.cs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   54.89%   54.97%   +0.07%     
==========================================
  Files         349      349              
  Lines       66481    66506      +25     
  Branches    13638    13640       +2     
==========================================
+ Hits        36498    36563      +65     
+ Misses      25992    25965      -27     
+ Partials     3991     3978      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mregen mregen merged commit 4740787 into main May 18, 2025
80 of 81 checks passed
@mregen mregen deleted the fixxmlencoding branch May 18, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants