hi,
I found an inconsistency in using HEX data characters in LocoNetEtherBuffer example.
When receiving, it decodes HEX data in uppercase ASCII (A-F) like in the examples of The LoconetOverTcp protocol (https://loconetovertcp.sourceforge.net/Protocol/LoconetOverTcp.html).
But, when sending it uses lowercase ASCII (a-f) using digitMap array for conversion:
const char digitMap[] = "0123456789abcdef";
It could lead to communications error if other device expects uppercase as stated in the LoconetOverTcp protocol.
The proposed change for conversion array will be:
const char digitMap[] = "0123456789ABCDEF";
regards,
Paco
hi,
I found an inconsistency in using HEX data characters in LocoNetEtherBuffer example.
When receiving, it decodes HEX data in uppercase ASCII (A-F) like in the examples of The LoconetOverTcp protocol (https://loconetovertcp.sourceforge.net/Protocol/LoconetOverTcp.html).
But, when sending it uses lowercase ASCII (a-f) using digitMap array for conversion:
const char digitMap[] = "0123456789abcdef";
It could lead to communications error if other device expects uppercase as stated in the LoconetOverTcp protocol.
The proposed change for conversion array will be:
const char digitMap[] = "0123456789ABCDEF";
regards,
Paco