Add support for custom formatting of progress#2
Open
lubomir wants to merge 2 commits intomrunderline:masterfrom
Open
Add support for custom formatting of progress#2lubomir wants to merge 2 commits intomrunderline:masterfrom
lubomir wants to merge 2 commits intomrunderline:masterfrom
Conversation
The default display of count/goal is not great when the progressbar tracks a large number like size of a downloaded file. This attribute allows setting a function that can process the value before it is printed.
While it was possible to get garbage characters before the previous commit by setting goal to a smaller value and reusing the same progressbar, the previous commit made it much more likely. Originally the size part could only grow, but now it can shrink. This commit adds just enough spaces to the printed line to cover up everything from the previous iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default display of count/goal is not great when the progressbar tracks a large number like size of a downloaded file.
This attribute allows setting a function that can process the value before it is printed.