This repository was archived by the owner on Jul 23, 2024. It is now read-only.
Add bin to path so devel\setup.bat works#7
Merged
seanyen merged 1 commit intoms-iot:init_windowsfrom Jan 30, 2019
ooeygui:init_windows
Merged
Add bin to path so devel\setup.bat works#7seanyen merged 1 commit intoms-iot:init_windowsfrom ooeygui:init_windows
seanyen merged 1 commit intoms-iot:init_windowsfrom
ooeygui:init_windows
Conversation
|
LGTM to add "bin" into the search path for Windows. @kejxu this could be an new change to upstream. |
kejxu
pushed a commit
to kejxu/pluginlib
that referenced
this pull request
Feb 20, 2019
seanyen
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Add bin to path so devel\setup.bat works (#7) * use _WIN32 and spaces Co-authored-by: Lou Amadio <ooeygui@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins do not work when you use the devel environment. Since windows drops the dll into the bin directory, they were just missing from the search path.