Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
export
wcn(), likecn()function of shadcn/uiWhy
In short: WindCtrl merges what it generates;
wcn()merges what the app/user adds on top.WindCtrl runs
twMerge(clsx(...))insidewindctrl()to resolve conflicts within the styles produced by the config (base / variants / traits / dynamic / scopes).However, in real apps you almost always need a second merge step at the component boundary:
classNameprop so callers can extend/override styles per usage.${generated} ${className}can reintroduce conflicts (e.g.p-2vsp-4), because the externalclassNameisn’t merged.wcn()is a tiny convenience helper (twMerge(clsx(inputs))) for that boundary merge:cn()utility (common in shadcn/cva projects)className={wcn(result.className, className)})