By default allowHalfOpen should be false#10
Closed
davidbz wants to merge 1 commit intomscdex:masterfrom
davidbz:allow_half_open_defaults
Closed
By default allowHalfOpen should be false#10davidbz wants to merge 1 commit intomscdex:masterfrom davidbz:allow_half_open_defaults
davidbz wants to merge 1 commit intomscdex:masterfrom
davidbz:allow_half_open_defaults
Conversation
Owner
|
That may be true for creating a |
Author
|
@mscdex thanks for your response. I'm running the following js code connecting to httpolyglot server and I end up getting CLOSE_WAIT connections. this is due to the fact that allowHalfOpen i set to true and there's no callback to end this connection. This does not happen on native node https server. any ideas? Thanks ` socket.connect(9000, 'localhost', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default allowHalfOpen should default to false (https://nodejs.org/api/net.html#net_new_net_socket_options)