Conversation
…ioning properly yet.
Still needs call functions to be able to run from terminal (thinking of making a print function for that.) And need to write tests.
fordf
reviewed
Dec 14, 2017
|
|
||
| def insert(self, val): | ||
| """Insert new node with data.""" | ||
| if self.val: |
There was a problem hiding this comment.
BinarySearchTree instances don't have val, left, right, or _counter attributes. Those are on the node instances.
There was a problem hiding this comment.
Whenever you start some process on a bst, you start from the root (which will be either a node or None) and traverse left or right from there. It's helpful if you have some variable that keeps track of which node you're currently comparing against.
| return self.right.val | ||
| return False | ||
|
|
||
| def breath_first(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.