Conversation
msimet
added a commit
that referenced
this pull request
Jul 14, 2018
msimet
added a commit
that referenced
this pull request
Jul 14, 2018
msimet
added a commit
that referenced
this pull request
Jul 14, 2018
msimet
added a commit
that referenced
this pull request
Nov 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow ScatterPlots to plot histograms, in the case where you have dense data and you think it'll look better.
Implementation detail: right now, it will ignore cases where you have available z-data (which is otherwise used to color the plots), rather than failing out. This is because there's some automatic routines in the ScatterPlots to find a size column used for color, and I don't want those to break someone's desire for a histogram since they won't know how to stop it.
Additionally, error bars must get ignored by the plotting since you're just binning up points, but they are still used to compute trendlines if requested.