fix: ensure RequestHandler type is accepted in setup functions#2676
Merged
kettanaito merged 3 commits intomswjs:fix/define-networkfrom Mar 19, 2026
Merged
Conversation
12 tasks
RequestHandler type is accepted in setup functions
kettanaito
approved these changes
Mar 19, 2026
Member
|
Thanks for raising this, @FelmonFekadu. I've improved the type tests to actually have assertions and cleaned up the manual |
Contributor
Author
|
Thanks for tightening that up and taking it the rest of the way. I appreciate the cleanup and the stronger type assertions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestHandlerinstances in the sharedAnyHandlertypesetupWorkerandsetupServercompatible with explicitly typedRequestHandler[]arraysVerification
Fixes the compatibility gap reported while testing #2650, where arrays typed as
RequestHandler[]no longer spread intosetupWorker/setupServer.