Open
Conversation
mtgto
reviewed
Jun 25, 2018
| }, | ||
| "include": [ | ||
| "strong-soap.d.ts", | ||
| "socks5-https-client.d.ts", |
Owner
There was a problem hiding this comment.
Please include this type definition file.
mtgto
requested changes
Jun 25, 2018
Owner
mtgto
left a comment
mtgto
left a comment
There was a problem hiding this comment.
yarn-error.log should not be included.
You might push force to abandon its file from git history.
| @@ -1,3 +1,7 @@ | |||
| export interface Option { | |||
| url: string; | |||
| proxy: { | |||
Owner
There was a problem hiding this comment.
Proxy option should be optional.
like:
export interface Option {
url: string;
proxy?: {
host: string;
port: number;
};
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to use a proxy via socks5-https-client