Skip to content

GTFS-RT > Trip Updates > Read from source > use header.timestamp #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmathieum merged 1 commit into from
Apr 23, 2026
Merged

GTFS-RT > Trip Updates > Read from source > use header.timestamp #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/main/java/org/mtransit/android/commons/provider/gtfs/GtfsRealTimeStorage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@ object GtfsRealTimeStorage {
PreferenceUtils.savePrefLclSync(context, PREF_KEY_TRIP_UPDATE_LAST_UPDATE_MS, lastUpdateInMs)
}

/**
* Override if multiple {@link GTFSRealTimeDbHelper} implementations in same app.
*/
private const val PREF_KEY_TRIP_UPDATE_READ_FROM_SOURCE_MS = "pGTFSRealTimeTripUpdatesReadFromSource"

@JvmStatic
@WorkerThread
fun getTripUpdateReadFromSourceMs(context: Context, default: Long) =
PreferenceUtils.getPrefLcl(context, PREF_KEY_TRIP_UPDATE_READ_FROM_SOURCE_MS, default)

@JvmStatic
@WorkerThread
fun saveTripUpdateReadFromSourceMs(context: Context, readFromSourceMs: Long?) {
PreferenceUtils.savePrefLclSync(context, PREF_KEY_TRIP_UPDATE_READ_FROM_SOURCE_MS, readFromSourceMs)
}

/**
* Override if multiple {@link GTFSRealTimeDbHelper} implementations in same app.
*/
Expand Down
14 changes: 11 additions & 3 deletions ...main/java/org/mtransit/android/commons/provider/status/GTFSRealTimeTripUpdatesProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package org.mtransit.android.commons.provider.status
import android.content.ComponentCallbacks2.TRIM_MEMORY_BACKGROUND
import android.content.Context
import android.util.Log
import com.google.transit.realtime.headerOrNull
import org.mtransit.android.commons.Constants
import org.mtransit.android.commons.MTLog
import org.mtransit.android.commons.SecurityUtils
Expand All @@ -16,6 +17,7 @@ import org.mtransit.android.commons.data.toNoData
import org.mtransit.android.commons.provider.GTFSRealTimeProvider
import org.mtransit.android.commons.provider.gtfs.GtfsRealTimeStorage
import org.mtransit.android.commons.provider.gtfs.GtfsRealtimeExt.optDirectionIdValid
import org.mtransit.android.commons.provider.gtfs.GtfsRealtimeExt.optTimestampMs
import org.mtransit.android.commons.provider.gtfs.GtfsRealtimeExt.optTrip
import org.mtransit.android.commons.provider.gtfs.GtfsRealtimeExt.sortTripUpdates
import org.mtransit.android.commons.provider.gtfs.GtfsRealtimeExt.toStringExt
Expand Down Expand Up @@ -112,8 +114,10 @@ object GTFSRealTimeTripUpdatesProvider : MTLog.Loggable {
filter: Schedule.ScheduleStatusFilter,
tripIds: List<String>
): POIStatus? {
val readFromSourceMs = GtfsRealTimeStorage.getTripUpdateLastUpdateMs(context, 0L)
val lastUpdateInMs = GtfsRealTimeStorage.getTripUpdateLastUpdateMs(context, 0L)
.takeIf { it > 0L } ?: return null // never loaded
val readFromSourceMs = GtfsRealTimeStorage.getTripUpdateReadFromSourceMs(context, 0L)
.takeIf { it > 0L } ?: lastUpdateInMs
val gTripUpdates = gTripUpdates ?: return null
val sourceLabel = SourceUtils.getSourceLabel( // always use source from official API
GTFSRealTimeProvider.getAgencyTripUpdatesUrlString(context, "T")
Expand Down Expand Up @@ -305,7 +309,9 @@ object GTFSRealTimeTripUpdatesProvider : MTLog.Loggable {
?.inputStream()
?.use { inputStream ->
try {
GFeedMessage.parseFrom(inputStream)
val gFeedMessage = GFeedMessage.parseFrom(inputStream)
GtfsRealTimeStorage.saveTripUpdateReadFromSourceMs(context, gFeedMessage.headerOrNull?.optTimestampMs)
gFeedMessage
.entityList
.toTripUpdates()
} catch (e: IOException) {
Expand Down Expand Up @@ -343,7 +349,9 @@ object GTFSRealTimeTripUpdatesProvider : MTLog.Loggable {
try {
val responseBodyByes = response.body.bytes()
File(context.cacheDir, GTFS_RT_TRIP_UPDATE_PB_FILE_NAME).writeBytes(responseBodyByes)
gTripUpdates = GFeedMessage.parseFrom(responseBodyByes).entityList.toTripUpdates() // will be used soon
val gFeedMessage = GFeedMessage.parseFrom(responseBodyByes)
GtfsRealTimeStorage.saveTripUpdateReadFromSourceMs(context, gFeedMessage.headerOrNull?.optTimestampMs)
gTripUpdates = gFeedMessage.entityList.toTripUpdates() // will be used soon
@Suppress("SimplifyBooleanWithConstants", "KotlinConstantConditions")
if (Constants.DEBUG && PRINT_ALL_LOADED_TRIP_UPDATES) {
MTLog.d(LOG_TAG, "loadAgencyDataFromWWW() > GTFS trip updates[${gTripUpdates?.size}]: ")
Expand Down