News providers > re-enable for main app

[mmathieum]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on reactivating and refining the news provider functionalities within the main application. The changes ensure that news content from various sources like Instagram, Twitter, YouTube, and RSS feeds can be properly targeted and displayed in the main app. It also includes minor code clean-up by standardizing empty string usage and suppressing specific lint warnings for improved code quality.

Highlights

• News Provider Re-enablement: Re-enabled Instagram, Twitter, YouTube, and RSS news providers for the main application by adjusting their targeting logic to allow the main app to target all news.
• Code Standardization: Standardized the usage of empty strings by replacing StringUtils.EMPTY with the direct import EMPTY across multiple news provider files.
• Lint Suppression: Added @Suppress annotations for SpellCheckingInspection and SimplifyBooleanWithConstants in Twitter and YouTube news providers to address specific lint warnings.

Changelog

• src/main/java/org/mtransit/android/commons/provider/InstagramNewsProvider.kt
  • Imported Constants and StringUtils.EMPTY.
  • Replaced StringUtils.EMPTY with EMPTY in several locations.
  • Modified news targeting logic to allow the main app package to target all news.
• src/main/java/org/mtransit/android/commons/provider/TwitterNewsProvider.kt
  • Imported Constants and StringUtils.EMPTY.
  • Added @Suppress("SpellCheckingInspection") annotations for USER_FIELDS and authorUserName.
  • Replaced StringUtils.EMPTY with EMPTY in various method calls.
  • Added logic to target all news for the main app package.
  • Added @Suppress("SimplifyBooleanWithConstants") to updateAllAgencyNewsDataFromWWW.
• src/main/java/org/mtransit/android/commons/provider/YouTubeNewsProvider.kt
  • Imported Constants and StringUtils.EMPTY.
  • Replaced StringUtils.EMPTY with EMPTY in update logic.
  • Reordered the import for YouTubeV3Api.
  • Added blank lines for improved readability.
  • Added @Suppress("SimplifyBooleanWithConstants") to updateAllAgencyNewsDataFromWWW.
  • Modified news targeting logic to allow the main app package to target all news.
• src/main/java/org/mtransit/android/commons/provider/news/rss/RssNewProviderUtils.kt
  • Imported StringUtils.EMPTY.
  • Added @Suppress("SpellCheckingInspection") to LABEL_BLACK_LIST.
  • Modified the pickTarget function to allow the main app package to target all news.
  • Adjusted the placement of the @JvmStatic annotation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request re-enables news providers for the main app and replaces StringUtils.EMPTY with EMPTY where appropriate. The changes involve importing Constants and StringUtils.EMPTY and using EMPTY directly. The use of @Suppress("SpellCheckingInspection") is added to suppress spell checking for certain variables.