Skip to content

Use shared MT setup action fully in dependency baseline workflow#688

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/update-mt-dependency-update-baseline
Draft

Use shared MT setup action fully in dependency baseline workflow#688
Copilot wants to merge 3 commits intomasterfrom
copilot/update-mt-dependency-update-baseline

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

mt-dependency-update-baseline.yml was still duplicating setup logic that already exists in the shared composite setup action. This PR aligns the workflow with the shared-overwrite convention by relying on MT setup for all duplicated setup behavior.

  • Workflow setup alignment

    • Updated .github/workflows/mt-dependency-update-baseline.yml to use:
      • mtransitapps/gh-actions/.github/actions/setup@v1.0.1 (name: MT setup, id: mt-setup)
    • Removed duplicated setup steps now covered by the shared action:
      • submodule checkout and branch switching
      • repository branch switching/pull setup
      • manual MT_GIT_BRANCH env setup step
      • explicit ./commons/code_setup.sh
      • direct tool setup steps:
        • actions/setup-java@v5
        • gradle/actions/setup-gradle@v6
    • Added repo-type env flags required by the shared action’s conditional setup logic:
      • MT_IS_SUBMODULE
      • MT_IS_MAIN_REPO
      • MT_IS_AGENCY_REPO
  • Resulting workflow shape

    • The job now delegates setup responsibilities to the shared MT setup action instead of maintaining local duplicates, reducing drift and centralizing setup behavior.
- name: MT setup
  id: mt-setup
  uses: mtransitapps/gh-actions/.github/actions/setup@v1.0.1

Copilot AI changed the title [WIP] Update mt-dependency-update-baseline.yml to use setup action Use shared MT setup action in dependency baseline workflow Apr 17, 2026
Copilot AI requested a review from mmathieum April 17, 2026 19:06
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot https://github.com/mtransitapps/gh-actions/blob/master/.github/actions/setup/action.yml the action does way more, please replace all the steps duplicated here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit 970353a: I removed the duplicated steps (checkout_submodules, submodule branch switching, module branch checkout/pull, MT_GIT_BRANCH setup, and ./commons/code_setup.sh) and now rely on mtransitapps/gh-actions/.github/actions/setup@v1.0.1 for that setup behavior.

@mmathieum mmathieum added the P4 🔽 Priority 4: Low label Apr 17, 2026
Copilot AI changed the title Use shared MT setup action in dependency baseline workflow Use shared MT setup action fully in dependency baseline workflow Apr 17, 2026
Copilot AI requested a review from mmathieum April 17, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P4 🔽 Priority 4: Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update mt-dependency-update-baseline.yml to use setup action

2 participants