Skip to content

Add promote from Prod to Prod 50%#713

Merged
mmathieum merged 6 commits intomasterfrom
mm/promote_prod_50
Apr 28, 2026
Merged

Add promote from Prod to Prod 50%#713
mmathieum merged 6 commits intomasterfrom
mm/promote_prod_50

Conversation

@mmathieum
Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Apr 28, 2026
@mmathieum mmathieum marked this pull request as ready for review April 28, 2026 12:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new shell script, promote_from_production_to_production_050.sh, to automate a 50% staged rollout for Android production releases. The review feedback focuses on improving script robustness and CI compatibility, specifically suggesting that skip conditions should return a success exit code (0) rather than an error (1) to avoid unnecessary pipeline failures. Additionally, the reviewer recommends double-quoting variable expansions to prevent word splitting and ensure consistent shell script execution.

Comment thread shared/app-android/promote_from_production_to_production_050.sh
Comment thread shared/app-android/promote_from_production_to_production_050.sh
Comment thread shared/app-android/promote_from_production_to_production_050.sh Outdated
Comment thread shared/app-android/promote_from_production_to_production_050.sh Outdated
mmathieum and others added 4 commits April 28, 2026 09:14
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mmathieum
Copy link
Copy Markdown
Member Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness and consistency of various shell scripts by quoting variables like $GIT_PROJECT_NAME and ${SCRIPT_DIR} to prevent word splitting and globbing issues. It also standardizes the formatting of promote.sh and publish.sh command calls across the Android deployment scripts and introduces a new script for a 50% production rollout. Feedback was provided regarding inconsistent formatting in the 100% production promotion script to ensure it aligns with the structure used in other rollout scripts.

Comment thread shared/app-android/promote_from_production_to_production_100.sh Outdated
@mmathieum mmathieum requested a review from Copilot April 28, 2026 13:41
@mmathieum mmathieum merged commit d093143 into master Apr 28, 2026
4 checks passed
@mmathieum mmathieum deleted the mm/promote_prod_50 branch April 28, 2026 13:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Play Store promotion helper script to ramp Production-to-Production rollouts to 50%, and standardizes quoting/formatting across existing bash release/promote scripts (especially for “old repo” *-gradle detection).

Changes:

  • Add promote_from_production_to_production_050.sh to promote Production → Production with --user-fraction 0.50.
  • Quote "$GIT_PROJECT_NAME" consistently in [[ ... == *"-gradle"* ]] checks.
  • Reformat several publish.sh / promote.sh wrapper invocations into multi-line commands for readability.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sync.sh Quotes GIT_PROJECT_NAME in old-repo detection when selecting submodules.
shared/publish_app_release.sh Quotes GIT_PROJECT_NAME for conditional extra GitHub release in old repo layout.
shared/commit_data_change.sh Quotes GIT_PROJECT_NAME for old-repo path selection during commits.
shared/app-android/publish_to_production_100.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_production_033.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_production_025.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_production_010.sh Quote setGitProjectName arg; multi-line publish.sh invocation and 0.10 formatting.
shared/app-android/publish_to_production_001.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_private_beta.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_internal.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/publish_to_current_users.sh Quote setGitProjectName arg for consistent path handling.
shared/app-android/publish_to_alpha.sh Quote setGitProjectName arg; multi-line publish.sh invocation.
shared/app-android/promote_from_production_to_production_100.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_production_to_production_050.sh New script to promote Production → Production at 50% user fraction.
shared/app-android/promote_from_production_to_production_033.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_production_to_production_025.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_production_to_production_010.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_private_beta_to_production_100.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_private_beta_to_production_033.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_private_beta_to_production_025.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_private_beta_to_production_010.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_private_beta_to_production_001.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_internal_to_alpha.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared/app-android/promote_from_alpha_to_private_beta.sh Quote setGitProjectName arg; multi-line promote.sh invocation.
shared-overwrite/submodules_init.sh Quotes GIT_PROJECT_NAME in old-repo submodule selection.
code_setup.sh Quotes GIT_PROJECT_NAME in old-repo submodule selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants