Add Content-Type header when sending JSON to /api/v2/spans#1
Closed
timhabermaas wants to merge 1 commit intomtth:masterfrom
Closed
Add Content-Type header when sending JSON to /api/v2/spans#1timhabermaas wants to merge 1 commit intomtth:masterfrom
timhabermaas wants to merge 1 commit intomtth:masterfrom
Conversation
Without the Content-Type Jaeger (tested using version 1.18) responded with "Unsupported Content-Type":
> curl -XPOST -d @foo2.json http://localhost:9411/api/v2/spans
Unsupported Content-Type
Author
|
This fix should be verifiable by using Jaeger's all-in-one Docker image (https://www.jaegertracing.io/docs/1.18/getting-started/#all-in-one) and pointing With the Content-Type set all seems to be working fine when sending data to Jaeger. Including tags and annotations (called events in Jaeger):
|
serras
added a commit
to serras/tracing
that referenced
this pull request
Jul 14, 2020
Owner
|
Thanks for the PR @timhabermaas and apologies for the slow reply. I wasn't getting notifications from this repo and am just going through the PRs now. I think this was fixed by #3. |
serras
added a commit
to serras/tracing
that referenced
this pull request
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the Content-Type Jaeger (tested using version 1.18) responded with "Unsupported Content-Type":