ci(arm64): fix llama.cpp build by adding googletest to CMakefile#2757
ci(arm64): fix llama.cpp build by adding googletest to CMakefile#2757
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
|
@mudler I'm looking at https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md#running-abseil-tests-with-cmake more closely, and it looks like there's two approaches here. We can either make abseil download the test dependencies... or see if we can skip testing abseil with the other flag. I'll try the latter in a separate PR, since I can't imagine we need to be running the abseil test suite in our pipeline - but if we do need to, try removing the manual download and using Edit: It's still in progress, but #2758 is already past the point we seem to be getting stuck on. Unless you can think of a good reason to actually care about Abseil's test cases as a part of our CI pipeline, I think that PR will obsolete this one. Edit 2: #2758 is past all the arm-related steps and is just working through the usual suspects. I think it's safe to say we can just disable running these tests for now - we are not patching abseil with custom code or anything, so we should have "herd immunity" from the many other projects who use this standardized library. The gRPC build / tests will end up exercising the portions we need anyway! |
|
Closing this, thanks @dave-gray101 ! |
Seems one more is required (see #2754)