Skip to content

fix: properly terminate llama.cpp kv_overrides array with empty key + updated doc #6672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 2 commits into from
Oct 23, 2025
Merged

fix: properly terminate llama.cpp kv_overrides array with empty key + updated doc #6672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6752769
fix: properly terminate kv_overrides array with empty key
blob42 Oct 22, 2025
86e14f6
doc: document the `overrides` option
blob42 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions backend/cpp/llama-cpp/grpc-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ static void params_parse(server_context& ctx_server, const backend::ModelOptions
}
}

if (!params.kv_overrides.empty()) {
params.kv_overrides.emplace_back();
params.kv_overrides.back().key[0] = 0;
}

// TODO: Add yarn

if (!request->tensorsplit().empty()) {
Expand Down
9 changes: 9 additions & 0 deletions docs/content/docs/advanced/advanced-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,15 @@ n_draft: 0
# Quantization settings for the model, impacting memory and processing speed.
quantization: ""
# List of KV Overrides for llama.cpp (--override-kv flag)
# Format: KEY=TYPE:VALUE
# Example: `qwen3moe.expert_used_count=int:10`
# Use this to override model configuration values at runtime.
# Supported types include: int, float, string, bool.
# Multiple overrides can be specified as a list.
overrides:
- KEY=TYPE:VALUE

# Utilization percentage of GPU memory to allocate for the model. (vLLM)
gpu_memory_utilization: 0

Expand Down
Loading