[POC] Minified context error message in prod#1248
Closed
atomiks wants to merge 1 commit intomui:masterfrom
Closed
Conversation
atomiks
commented
Dec 30, 2024
Comment on lines
+1
to
+3
| export function productionContextError(): never { | ||
| throw new Error('Base UI: Invalid component tree'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
React's minified errors link to a webpage that details the error, but this seems unnecessary for invalid component trees since it's certain to be encountered while developing beforehand
Netlify deploy preview |
Member
|
This will surely shave off a few bytes but looks quite bad in source code. Have you considered using a similar solution to what's in Material UI? We have a Babel macro that minifies these messages. |
Contributor
Author
Do you have a link/example of the source? |
Member
Check out this PR mui/material-ui#43904 😬 |
Contributor
Author
|
Replaced by #1463 |
oliviertassinari
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1246