[Tooltip, PreviewCard] Use FloatingPortalLite#1278
Merged
atomiks merged 2 commits intomui:masterfrom Jan 8, 2025
Merged
Conversation
atomiks
added
component: tooltip
Netlify deploy preview |
atomiks
force-pushed
the
feat/floating-portal-lite
branch
from
6a6c05d to
077387c
Compare
michaldudak
approved these changes
Jan 7, 2025
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
LGTM.
Side note: I'd appreciate it if you could write more verbose PR descriptions, so in a year from now, it's easier to figure out why a particular piece of code was added.
Contributor
Author
|
@michaldudak updated description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1246. Depends on refactors made in #1222
This prevents bringing in tabbable logic (
tabbabledependency and extra code from Floating UI) if just importing theTooltiporPreviewCardcomponents, saving bundle size