[Toolbar] POC with context checking API#1437
Closed
mj12albert wants to merge 17 commits intomui:masterfrom
Closed
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
Issues so far:
2/3 could possibly be worked around by not using Not sure if anything can be done about 1, it doesn't seem ideal to expose |
mj12albert
commented
Feb 11, 2025
| import { useToolbarRootContext, type ToolbarRootContext } from './ToolbarRootContext'; | ||
| import type { ToolbarItemMetadata } from './ToolbarRoot'; | ||
|
|
||
| function useCompositeButton(parameters: useCompositeButton.Parameters) { |
Member
Author
There was a problem hiding this comment.
(this is super rough right now, don't look too closely)
Member
Author
|
Going with the original API in #661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo: https://deploy-preview-1437--base-ui.netlify.app/experiments/toolbar/text-editor
Full source: https://github.com/mui/base-ui/blob/2eae6834348d70804ca94c93f97c04b2f4738adf/docs/src/app/(private)/experiments/toolbar/text-editor.tsx
Forked from #1349