[code-infra] Migrate error code extraction to code-infra by brijeshb42 · Pull Request #2670 · mui/base-ui

brijeshb42 · 2025-09-05T13:30:40Z

I have followed (at least) the PR section of the contributing guide.

https://deploy-preview-2670--base-ui.netlify.app/production-error?code=1

brijeshb42 · 2025-09-05T13:31:38Z

packages/utils/src/store/createSelector.ts

    selector = a;
  } else {
-    throw new Error('Missing arguments');
+    throw /* minify-error-disabled */ new Error('Missing arguments');


Doesn't really save that much.

pkg-pr-new · 2025-09-05T13:32:14Z

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2670

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2670

commit: 4e1c986

netlify · 2025-09-05T13:32:48Z

✅ Deploy Preview for base-ui ready!

Name	Link
🔨 Latest commit	`4e1c986`
🔍 Latest deploy log	https://app.netlify.com/projects/base-ui/deploys/68ef9dbb9360ba0008b3bf61
😎 Deploy Preview	https://deploy-preview-2670--base-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

brijeshb42 · 2025-09-05T13:31:45Z

packages/utils/src/store/createSelector.ts

      case 3: return fn(state, a1, a2, a3);
      default:
-        throw new Error('unreachable');
+        throw /* minify-error-disabled */ new Error('unreachable');


brijeshb42 · 2025-09-05T13:32:08Z

packages/utils/src/formatErrorMessage.ts

+ *   ...
+ */
+export default function formatErrorMessage(code: number, ...args: string[]): string {
+  const url = new URL(`https://base-ui.com/production-error/${code}`);


Implemented here #1463

It can be this or https://base-ui.com/production-error?code=${code}

brijeshb42 · 2025-09-05T13:32:37Z

packages/utils/src/useEventCallback.ts

-  if (process.env.NODE_ENV !== 'production') {
-    throw new Error('Base UI: Cannot call an event handler while rendering.');
-  }
+  throw new Error('Base UI: Cannot call an event handler while rendering.');


NODE_ENV check not needed now with extraction enabled.

mui-bot · 2025-09-05T13:44:54Z

Bundle size report

Bundle	Parsed size	Gzip size
@base-ui-components/react	▼-5.49KB^(-1.45%)	▼-950B^(-0.79%)

Details of bundle changes

brijeshb42 · 2025-10-10T08:49:42Z

docs/src/app/(public)/(content)/production-error/ErrorDisplay.tsx

+'use client';
+import * as React from 'react';
+import { useSearchParams } from 'next/navigation';
+import codes from 'docs/src/error-codes.json';


We can have basic inline markdown formatting rendering in a followup.

Janpot · 2025-10-15T12:37:34Z

packages/utils/src/useEventCallback.ts

@@ -46,6 +46,8 @@ function createStableCallback() {

 function assertNotCalled() {
  if (process.env.NODE_ENV !== 'production') {


🤔 That's a case we may be able to detect in the babel plugin

Janpot

Looks good from my end 👍

brijeshb42 · 2025-10-15T13:19:55Z

@mui/base-ui Can I get a review/approval ?

LukasTy

LGTM overall.
Great work. 👍

LukasTy · 2025-10-15T14:36:07Z

docs/README.md

+1. There hasn't been an update to the semantic meaning of the error message. Error codes need to outlive Base UI versions, so the same code must mean the same thing across versions.
+2. There hasn't been a change in parameters, no added and no removed.


Won't this be "hardish" to maintain without automation as time goes by? 🤔

brijeshb42 requested a review from a team September 5, 2025 13:30

brijeshb42 requested review from atomiks, colmtuite and michaldudak as code owners September 5, 2025 13:30

brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Sep 5, 2025

brijeshb42 commented Sep 5, 2025

View reviewed changes

brijeshb42 mentioned this pull request Sep 5, 2025

[code-infra] Add cli to extract error codes independent of build mui/mui-public#641

Merged

brijeshb42 force-pushed the error-code-extraction branch from 1516364 to 10cb971 Compare September 5, 2025 13:42

brijeshb42 force-pushed the error-code-extraction branch 5 times, most recently from d936046 to 2dbc69c Compare September 5, 2025 14:54

oliviertassinari changed the title ~~[infra] Migrate error code extraction to code-infra~~ [code-infra] Migrate error code extraction to code-infra Sep 6, 2025

oliviertassinari added the performance label Sep 6, 2025

brijeshb42 force-pushed the error-code-extraction branch 3 times, most recently from 604f17f to 3e1029c Compare September 8, 2025 11:17

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 8, 2025

brijeshb42 force-pushed the error-code-extraction branch from 3e1029c to 4a7124d Compare September 8, 2025 15:18

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Sep 8, 2025

brijeshb42 force-pushed the error-code-extraction branch from 4a7124d to 187001a Compare September 29, 2025 06:53

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 29, 2025

[infra] Migrate error code extraction to code-infra

43d8fdd

brijeshb42 force-pushed the error-code-extraction branch from 187001a to 43d8fdd Compare September 29, 2025 07:12

brijeshb42 requested a review from Janpot September 29, 2025 07:21

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 29, 2025

Add docs

4e4f10c

Janpot mentioned this pull request Sep 30, 2025

[code-infra] Setup error message minification #1463

Closed

Janpot added 6 commits September 30, 2025 11:57

Update ErrorCode.tsx

81c053b

Update pnpm-lock.yaml

3505a82

Update ErrorDisplay.tsx

6308dd2

Update reportBrokenLinks.mts

885dbb9

Update .markdownlint-cli2.mjs

52d715e

Merge remote-tracking branch 'upstream/master' into pr/2670

126e002

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 30, 2025

Merge branch 'master' into error-code-extraction

769a562

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 2, 2025

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 10, 2025

brijeshb42 commented Oct 10, 2025

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 14, 2025

Janpot reviewed Oct 15, 2025

View reviewed changes

Merge branch 'master' into error-code-extraction

990b77c

brijeshb42 force-pushed the error-code-extraction branch from e6da500 to 0a4803a Compare October 15, 2025 12:54

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 15, 2025

Update error-codes file

4e1c986

brijeshb42 force-pushed the error-code-extraction branch from 0a4803a to 4e1c986 Compare October 15, 2025 13:12

LukasTy approved these changes Oct 15, 2025

View reviewed changes

brijeshb42 merged commit bde10f6 into mui:master Oct 16, 2025
20 checks passed

		@@ -46,6 +46,8 @@ function createStableCallback() {

		function assertNotCalled() {
		if (process.env.NODE_ENV !== 'production') {

		1. There hasn't been an update to the semantic meaning of the error message. Error codes need to outlive Base UI versions, so the same code must mean the same thing across versions.
		2. There hasn't been a change in parameters, no added and no removed.

Uh oh!

Conversation

brijeshb42 commented Sep 5, 2025 • edited by Janpot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for base-ui ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mui-bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle size report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot left a comment

Choose a reason for hiding this comment

Uh oh!

brijeshb42 commented Oct 15, 2025

Uh oh!

LukasTy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

brijeshb42 commented Sep 5, 2025 •

edited by Janpot

Loading

pkg-pr-new bot commented Sep 5, 2025 •

edited

Loading

netlify bot commented Sep 5, 2025 •

edited

Loading

mui-bot commented Sep 5, 2025 •

edited

Loading