[website] Fix /base-ui/ code duplication

[oliviertassinari]

Randomly delete files of https://mui.com/base-ui/ that are duplicated to make sure we don't try to use them (they will go out of sync).

Preview: https://deploy-preview-416--base-ui.netlify.app/

[mui-bot]

Netlify deploy preview

https://deploy-preview-416--base-ui.netlify.app/

Generated by 🚫 dangerJS against 81bfc4e

[michaldudak]

I don't understand the purpose of this PR. These files are indeed duplicated, but this copy should be the source of truth as we're going to host the live docs from this repo.

[oliviertassinari]

I removed the source of this page https://mui.com/base-ui/ and only because the source we have in Base UI isn't used in production, we made changes to the source of https://mui.com/base-ui/ since from http://github.com/mui/material-ui. I believe it's clearer this way (no duplication).

[michaldudak]

It doesn't really matter if they aren't in sync. What we have here will ultimately replace the landing page that's currently live at mui.com.
The changes proposed in this PR make PR previews basically unusable if you don't have the deep URL: https://deploy-preview-416--base-ui.netlify.app/base-ui/

cc @colmtuite

[colmtuite]

@michaldudak Agreed, it's fine if they're out-of-sync.

[oliviertassinari]

Would it work if we make it behave like with MUI X https://master--material-ui-x.netlify.app (the redirection) in the meantime? No strong preference, my initial objective was to make it impossible to not sync back these pages in Base UI from their current state in the main repository.

What we have here will ultimately replace the landing page that's currently live at mui.com.

Oh, interesting, so the plan is Option C? https://www.notion.so/mui-org/docs-infra-Marketing-site-code-location-70fa836aeb654e2eb429721706529e1d?pvs=4#a0a3f8db560b42ce8d6c4626b6741fc8. It wasn't clear to me if we found a solution to this problem.

Off-topic. On what we have in the page today, some of the ideas to push it further mui/material-ui#36622 (comment)

[colmtuite]

@oliviertassinari My preference is option B, but it seems option C won.

[oliviertassinari]

Ok, for now I'm aiming for a simple goal with this PR: removing the code duplication in the codebase. I have fixed the problem @michaldudak raised with the URLs by coping MUI X's approach. We now have these links that I believe behave correctly:

• https://deploy-preview-416--base-ui.netlify.app/base-ui/
• https://deploy-preview-416--base-ui.netlify.app/

Going forward, the fate of https://github.com/mui/material-ui/blob/next/docs/pages/base-ui.tsx will depend on https://www.notion.so/mui-org/docs-infra-Marketing-site-code-location-70fa836aeb654e2eb429721706529e1d.

[michaldudak]

Oh, interesting, so the plan is Option C? https://www.notion.so/mui-org/docs-infra-Marketing-site-code-location-70fa836aeb654e2eb429721706529e1d?pvs=4#a0a3f8db560b42ce8d6c4626b6741fc8. It wasn't clear to me if we found a solution to this problem.

I wasn't aware of this discussion. It felt natural to me to keep all Base UI-related docs in our repo so we can own them, style them and host them separately if there's a need to.
It feels weird to me that everything but the landing page is in our repo, but if y'all prefer it this way, so be it.

[colmtuite]

@oliviertassinari @michaldudak Can we undo this merge somehow? We previously decided to keep the marketing page and docs separate, because we're not sure yet how to manage the styling/structure/usability/a11y of the docs and website. Also, nobody approved this PR, and I don't think any PRs should be merged without approval.

[oliviertassinari]

@colmtuite We can definitely do the opposite (remove the page from Material UI repository and have Base UI page what's shows in production from this repository). The problem is that we fixed stuff in https://github.com/mui/material-ui/blob/next/docs/pages/base-ui.tsx that isn't propagated in this repository, the content we have here is outdated. So IMHO, it's not about reverting this PR, but transfering the code from the Material UI repository to here and then putting it in production.

[michaldudak]

My take on it is that we should revert this PR but keep the landing page in the Core repo for now. Once we're ready with the new website (have enough components to build a nice landing page, etc.), we remove all Base UI-related code and docs from the Core repo and either have everything in this repo (option C) or in yet another repo (option C).

[colmtuite]

Yes I agree with @michaldudak.

[oliviertassinari]

It feels like I'm missing something, I would have expected this PR to go without friction (why I merged straight, I wanted a PR to see the CI checks, why I didn't push a commit straight to HEAD).
What problem are we trying to solve with having https://github.com/mui/material-ui/blob/next/docs/pages/base-ui.tsx in this repository, but with outdated content (code that we will have to delete eventually since would have forked too much) and that is only visible in PR previews? I fail there 😄. I'm happy with any path that doesn't have code duplicating in the codebase (our codebase is the HEAD of mui-private + mui-public + material-ui + base-ui + pigment-css repositories).