[internal] Make React context definitions consistent#735
Merged
michaldudak merged 5 commits intomui:masterfrom Oct 17, 2024
Merged
[internal] Make React context definitions consistent#735michaldudak merged 5 commits intomui:masterfrom
michaldudak merged 5 commits intomui:masterfrom
Conversation
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
1 task
github-actions
bot
removed
the
PR: out-of-date
michaldudak
force-pushed
the
consistent-context
branch
from
691c6c8 to
bd31a3e
Compare
github-actions
bot
added
the
PR: out-of-date
atomiks
approved these changes
Oct 17, 2024
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
changed the title
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
Cool, thanks for the context display name fixes.
| } | ||
|
|
||
| export const RadioRootContext = React.createContext<RadioRootContext | null>(null); | ||
| export const RadioRootContext = React.createContext<RadioRootContext | undefined>(undefined); |
Member
There was a problem hiding this comment.
set default value of contexts to undefined (was a mix of undefined and null previously)
Ok, so a new standard. I think we can standardize on this in Material UI and X too.
atomiks
pushed a commit
to atomiks/base-ui
that referenced
this pull request
Oct 30, 2024
oliviertassinari
added
internal
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefined(was a mix ofundefinedandnullpreviously)displayNamein non-production environment (closes [all components] Missing React.createContext displayName #628)Closes #520