Skip to content

[Modal] Issue with overflow-y: scroll on <html> #34513

@nuanyang233

Description

@nuanyang233

Summary 💡

Add scrollContainer to support custom scroll lock containers.

Examples 🌈

Our product is a browser plugin that enables some features on social platforms. We have implemented some features on Twitter and used dialog. But since twitter implements overflow on the html node.

image

Motivation 🔦

However, scrollLock currently only works on the body node. And developers cannot customize the nodes that require scroll lock.

So I implemented a simple patch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accessibilitya11yscope: modalChanges related to the modal.type: new featureExpand the scope of the product to solve a new problem.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions