[Modal] Prefer to lock scroll on body than html element#18445
Merged
oliviertassinari merged 2 commits intomui:masterfrom Nov 19, 2019
Merged
[Modal] Prefer to lock scroll on body than html element#18445oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari merged 2 commits intomui:masterfrom
Conversation
Details of bundle changes.Comparing: 9c2f734...66000c1
|
bf39cff to
ddedc56
Compare
oliviertassinari
approved these changes
Nov 19, 2019
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
Thanks for fixing the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #18336
Summary:
Changing overflow on the html element may/will reset the page scroll position, in particular when overflow is already applied to the body element.
This change restores behavior prior to #17972 unless overflow is already applied to the html element.