Skip to content

[List] Fix demo to have correct semantic#26742

Merged
siriwatknp merged 2 commits intomui:nextfrom
siriwatknp:fix/lists-demo
Jun 15, 2021
Merged

[List] Fix demo to have correct semantic#26742
siriwatknp merged 2 commits intomui:nextfrom
siriwatknp:fix/lists-demo

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 14, 2021

@siriwatknp siriwatknp changed the title [List] fix simple list demo to have correct semantic [List] fix demo to have correct semantic Jun 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 14, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 5211ef0

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are on this demo, we might as well rename the header to match the other pages "## Basic list"?

@oliviertassinari oliviertassinari added scope: list Changes related to the list docs Improvements or additions to the documentation. labels Jun 14, 2021
@siriwatknp
Copy link
Member Author

If we are on this demo, we might as well rename the header to match the other pages "## Basic list"?

sure, no strong opinion.

@siriwatknp siriwatknp merged commit f5ff015 into mui:next Jun 15, 2021
@siriwatknp siriwatknp deleted the fix/lists-demo branch June 15, 2021 05:51
@oliviertassinari oliviertassinari changed the title [List] fix demo to have correct semantic [List] Fix demo to have correct semantic Jun 15, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 15, 2021

Thanks for the follow-up 👍

I have changed the title with an upper case F to match the existing arbitrary title convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: list Changes related to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants