[Alert] Add support for CSS vars#32624
[Alert] Add support for CSS vars#32624siriwatknp merged 6 commits intomui:masterfrom verbose117:css-vars-alert
Conversation
|
@material-ui/core: parsed: +0.55% , gzip: +0.29% |
danilo-leal
added
scope: alert
|
The Alert needs to wait for a discussion about how to deal with |
I just changed the needed, and was waiting for the info about it |
|
@haneenmahd we have a resolution for the problem in #32049 (comment) Feel free to continue with the effort. |
| errorColor: string; | ||
| infoColor: string; | ||
| successColor: string; | ||
| warningColor: string; | ||
| errorFilledBg: string; | ||
| infoFilledBg: string; | ||
| successFilledBg: string; | ||
| warningFilledBg: string; | ||
| errorStandardBg: string; | ||
| infoStandardBg: string; | ||
| successStandardBg: string; | ||
| warningStandardBg: string; | ||
| errorIconColor: string; | ||
| infoIconColor: string; | ||
| successIconColor: string; | ||
| warningIconColor: string; |
There was a problem hiding this comment.
@mnajdova I could not see other ways to reduce the number of tokens if we want to keep the same behavior. 😢
There was a problem hiding this comment.
Would be tricky if people add custom colors here :\ Should we maybe create these based on the PaletteOptions type?
There was a problem hiding this comment.
I don't think we should go that far for now. There is a trade-off because some people might not want the autogenerated variables (increase in bundle size) and we need to create more APIs to let them exclude things that they don't want.
At this point, I think we can leave the new custom palette effort to the developers and make sure that the docs are clear and comprehensive.
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
👍 Last PR for CSS variables support. I'm pumped!
|
sorry, for asking but what exactly needed to be changed RN? |
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Overall looks good, left one comment on the types.
5 participants
Add support for CSS variables for the component
Alert(#32049).guide.