Bump eslint-plugin-react to ^7.30.1#33027
Merged
michaldudak merged 2 commits intomasterfrom Jul 26, 2022
Merged
Conversation
|
Your Render PR Server URL is https://mui-pr-33027.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cadvu9fd17c944c09d10. |
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
ccfc057 to
9ab2d3c
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
9ab2d3c to
8f672ea
Compare
github-actions
bot
added
the
PR: out-of-date
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
8f672ea to
286f816
Compare
github-actions
bot
added
PR: out-of-date
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
286f816 to
8f35e29
Compare
github-actions
bot
added
PR: out-of-date
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
8f35e29 to
f5bd2a1
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
f5bd2a1 to
f389f17
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
9b2b8ae to
95ef67c
Compare
| } | ||
|
|
||
| FixtureRenderer.propTypes = { | ||
| component: PropTypes.element, |
Member
There was a problem hiding this comment.
This should have been:
Suggested change
| component: PropTypes.element, | |
| component: PropTypes.elementType, |
It's a React component, not a React element.
Comment on lines
+138
to
+140
| // No need to check this as prop types are autogenerated. | ||
| // Plus, there are a few false positives. | ||
| 'react/no-unused-prop-types': 'off', |
Member
There was a problem hiding this comment.
Looking at https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-unused-prop-types.md and mui/toolpad#866 (comment), it seems that we should revert. This impacts TypeScript too.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Michał Dudak <michal@dudak.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.29.4->^7.30.1Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.