You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add Base example to leverage the CodeSandbox package build in PRs. This PR started from my need to test the fix in #33145 via CodeSandbox (it is possible to manually install via command line but it is a slow process).
I'm wondering what styling solution should we use. I'm not convinced about emotion. If we want to showcase a CSS-in-JS solution, we could advertise our System here. But also we could go as simple as possible and use plain CSS. Or maybe we need two examples ;)
I'm wondering what styling solution should we use. I'm not convinced about emotion. If we want to showcase a CSS-in-JS solution, we could advertise our System here. But also we could go as simple as possible and use plain CSS. Or maybe we need two examples ;)
I oppose with plain CSS (if I have to create another file and come up with a class name, it is KO for me) but I totally agree with using @mui/system instead of emotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Base example to leverage the CodeSandbox package build in PRs. This PR started from my need to test the fix in #33145 via CodeSandbox (it is possible to manually install via command line but it is a slow process).
This is what the App.tsx looks like: