Closed
Conversation
Member
siriwatknp
commented
Jul 11, 2022
siriwatknp
commented
- I have followed (at least) the PR section of the contributing guide.
michaldudak
reviewed
Jul 11, 2022
| ### `@mui/base@5.0.0-alpha.89` | ||
|
|
||
| - ​<!-- 29 -->[Base] Add MUI base example (#33154) @siriwatknp | ||
| - ​<!-- 28 —>[Base] Change the order of class names merged in useSlotProps (#33383) @michaldudak |
Member
There was a problem hiding this comment.
Suggested change
| - ​<!-- 28 —>[Base] Change the order of class names merged in useSlotProps (#33383) @michaldudak | |
| - ​<!-- 28 -->[Base] Change the order of class names merged in useSlotProps (#33383) @michaldudak |
or just remove the prefixes altogether
Member
Author
There was a problem hiding this comment.
I'll remove them all.
| - ​<!-- 19 -->[docs] Add "refine" demo to showcase (#33240) @omeraplak | ||
| - ​<!-- 18 -->[docs] Add webpack alias for legacy utils package (#33376) @jgbae | ||
| - ​<!-- 16 -->[docs] Improve external link icons synonyms (#33257) @davidgarciab | ||
| - ​<!-- 31 —>[docs] Correcting small grammatical error (#33393) @robyyo |
Member
There was a problem hiding this comment.
It seems like whatever editor you're using thinks it's smarter ;)
Suggested change
| - ​<!-- 31 —>[docs] Correcting small grammatical error (#33393) @robyyo | |
| - ​<!-- 31 -->[docs] Correcting small grammatical error (#33393) @robyyo |
Member
Author
|
closed this in favor of #33483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.