[Grid] Export new grid as unstable#33479
Merged
siriwatknp merged 11 commits intomui:masterfrom Jul 12, 2022
Merged
Conversation
|
@material-ui/core: parsed: +1.04% , gzip: +1.22% |
siriwatknp
commented
Jul 12, 2022
| MuiFormHelperText: FormHelperTextClassKey; | ||
| MuiFormLabel: FormLabelClassKey; | ||
| MuiGrid: GridClassKey; | ||
| MuiGrid2: Grid2Slot; |
Member
Author
There was a problem hiding this comment.
I think we can start to use slot instead of class key.
mnajdova
reviewed
Jul 12, 2022
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import Grid from '@mui/system/Grid'; | |||
| import Grid from '@mui/system/Unstable_Grid'; | |||
Member
There was a problem hiding this comment.
It might have been clearer with:
Suggested change
| import Grid from '@mui/system/Unstable_Grid'; | |
| import Grid from '@mui/system/Unstable_Grid2'; |
under the idea that the code namespace is unique inside MUI, and for Joy. I mean, for the developers using both, switching between the libraries based on the project/part of the apps.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage
System
From the package perspective, System does not have
Gridbefore so no need to suffix with 2.Material UI
Mark it as unstable to inform developers that this component is a new one that we want to test out. Also, use
Grid2to implicitly explain that this is the new version of theGrid.🧪 https://codesandbox.io/s/create-react-app-with-typescript-forked-bisql4?file=/src/App.tsx
Joy UI
// since Joy is still in alpha, I don't think the
Unstableis needed.🧪 https://codesandbox.io/s/joy-cra-typescript-forked-lx29lg?file=/src/App.tsx