[internal] Remove unnecessary packageName attribute from pages#33488
Merged
oliviertassinari merged 1 commit intomui:masterfrom Aug 5, 2022
Merged
Conversation
cherniavskii
added
the
internal
cherniavskii
commented
Jul 12, 2022
| @@ -1,9 +1,8 @@ | |||
| --- | |||
| product: material-ui | |||
| product: base | |||
Member
Author
There was a problem hiding this comment.
some pages like this one had outdated product attribute
Contributor
There was a problem hiding this comment.
Looks like these are all in the translated pages, which we don't generally edit directly. (I'm not sure why exactly.)
Member
There was a problem hiding this comment.
I'm not sure why exactly.
https://www.notion.so/mui-org/Translations-1c9ad92060cb4bb49669ab5e1c0bbb8e: tries to answer this question.
Member
Author
There was a problem hiding this comment.
So it looks like Crowdin will update product field as well, but only when there's an update to this page's translation.
If I understand it correctly, there should be no problem with updating it manually in this PR.
Member
|
@cherniavskii Great, thanks! |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #33439
Since
ComponentLinkHeadernow has defaultpackageNamefor eachproduct, it's safe to remove most ofpackageNameusage in pages:material-ui/docs/src/modules/components/ComponentLinkHeader.js
Lines 30 to 35 in 88ad7d4
Now
packageNamein only used on few pages that need to override it (@mui/laband@mui/icons-materialinmaterial-uiproduct)https://deploy-preview-33488--material-ui.netlify.app/base/react-badge/