[internal] Fix scroll restoration in the docs#34037
Merged
oliviertassinari merged 2 commits intomui:masterfrom Aug 23, 2022
Merged
[internal] Fix scroll restoration in the docs#34037oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari merged 2 commits intomui:masterfrom
Conversation
| ThemeProvider as MuiThemeProvider, | ||
| createTheme as createLegacyModeTheme, | ||
| unstable_createMuiStrictModeTheme as createStrictModeTheme, | ||
| createTheme, |
Member
Author
There was a problem hiding this comment.
The same module is exported under these two names since v5.
| <Stack direction="row" spacing={2}> | ||
| <Chip label="React" color="primary" onDelete={() => {}} /> | ||
| <Chip label="Javascript" onDelete={() => {}} /> | ||
| <Chip label="JavaScript" onDelete={() => {}} /> |
Member
Author
7a47cc5 to
153b2d1
Compare
mnajdova
approved these changes
Aug 23, 2022
|
|
||
| module.exports = { | ||
| ...baseline, | ||
| baseline, // Exported so the other projects can use this configuration directly. |
flaviendelangle
approved these changes
Aug 23, 2022
Member
flaviendelangle
left a comment
There was a problem hiding this comment.
Not very familiar with these portions of the architecture, but it look good to me
This was referenced Aug 28, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #33196 (comment) using vercel/next.js#37893 (comment)
Before: http://mui.com/
After: https://deploy-preview-34037--material-ui.netlify.app/
I have also made a change so that MUI X and MUI Toolpad can do:
They should get this bug fix for free, not have to apply it again.