[docs] Improve social sharing of docs pages#34346
Merged
oliviertassinari merged 1 commit intomui:masterfrom Sep 20, 2022
Merged
[docs] Improve social sharing of docs pages#34346oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
| const card = | ||
| headers.card === 'true' | ||
| ? `https://mui.com/static${router.pathname}/card.png` | ||
| ? `https://mui.com/static/blog/${slug}/card.png` |
Member
Author
There was a problem hiding this comment.
A small fix. It helps to search in the codebase for places were the images inside the blog folder are used.
danilo-leal
approved these changes
Sep 20, 2022
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looks good! I'd love to generate automatically the ones I've been manually doing for each blog post (see attachment)－we could then think about similar ones for doc pages.
Member
Author
Agree, a couple of options:
|
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same rationale as #32536. When sharing a page to a specific docs page, the social image creates confusion https://twitter.com/olivtassinari/status/1571093885644046339.
Going forward, I think that we have two opportunities to improve, by increasing effort & outcome:
A bit related to #32181