[docs] Fix codesandbox export with dayjs#34619
Merged
oliviertassinari merged 1 commit intomui:masterfrom Oct 5, 2022
Merged
Conversation
1 task
flaviendelangle
approved these changes
Oct 5, 2022
Member
|
Will be applied to MUI-X in mui/mui-x#6103 |
oliviertassinari
added
the
scope: docs-infra
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since mui/mui-x#5481 the bug is a lot more visible. When you export a codesandbox from https://mui.com/x/react-date-pickers/date-picker/#basic-usage
you will get https://codesandbox.io/s/3sem4m?file=/package.json:161-172
but this package doesn't exist. Dayjs already includes the types, proof: https://unpkg.com/browse/dayjs@1.11.5/index.d.ts.
I found this while I was doing a bit of support in https://groups.google.com/a/mui.com/g/x/c/xHe-_HUVhjc.