Skip to content

[docs] Fix missing emotion prefixes#34958

Merged
mnajdova merged 1 commit into
mui:masterfrom
oliviertassinari:fix-prefixer
Oct 31, 2022
Merged

[docs] Fix missing emotion prefixes#34958
mnajdova merged 1 commit into
mui:masterfrom
oliviertassinari:fix-prefixer

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari commented Oct 30, 2022

This fixes a regression introduced in #33545. I have notice it when I was looking at the screenshot of #34859, it looked wrong, the header background is meant to be blurred:

Screenshot 2022-10-30 at 21 37 38

Why does this happen? Because of https://github.com/emotion-js/emotion/blob/d8a13bcae81812d3dff643bcf446709f965f0909/packages/cache/src/index.js#L84. My end goal is to get a nice reading experience for the blog on iOS.

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. docs Improvements or additions to the documentation. type: regression A bug, but worse, it used to behave as expected. labels Oct 30, 2022
@mui-bot
Copy link
Copy Markdown

mui-bot commented Oct 30, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34958--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 5db7f19

Copy link
Copy Markdown
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Found this too! Thanks for the fix.

@mnajdova mnajdova merged commit ff26e71 into mui:master Oct 31, 2022
@oliviertassinari oliviertassinari deleted the fix-prefixer branch October 31, 2022 10:31
@oliviertassinari oliviertassinari added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Nov 21, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@oliviertassinari oliviertassinari removed the type: bug It doesn't behave as expected. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants