[website] Exclude experiment pages in production#35180
Merged
siriwatknp merged 9 commits intomui:masterfrom Nov 21, 2022
Merged
[website] Exclude experiment pages in production#35180siriwatknp merged 9 commits intomui:masterfrom
siriwatknp merged 9 commits intomui:masterfrom
Conversation
Member
siriwatknp
commented
Nov 17, 2022
siriwatknp
commented
- I have followed (at least) the PR section of the contributing guide.
siriwatknp
added
website
|
Member
Author
|
@oliviertassinari currently, the experiment pages work in https://mui.com/experiments/, is this what you expected? |
Member
|
@siriwatknp Ah, awesome. I didn't intend this change in #34259, so it looks like I introduced a regression. I assume you worked on this because of #35173? |
oliviertassinari
approved these changes
Nov 17, 2022
Member
Author
Not entirely but it reminds me to fix this problem because I tried to open the experiment pages in the deploy preview PRs but it did not work 😅. |
siriwatknp
commented
Nov 18, 2022
oliviertassinari
force-pushed
the
docs/skip-experiments
branch
from
2fd947d to
6baa60c
Compare
… about something unrelated
Member
|
@siriwatknp Looks good, I have made a few light changes, trying to further improve it. |
…t index the staging envs
oliviertassinari
force-pushed
the
docs/skip-experiments
branch
from
2aaf894 to
422d883
Compare
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Nov 22, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.