redirect next.mui.com/x/* to mui.com/x/*#36296
redirect next.mui.com/x/* to mui.com/x/*#36296cherniavskii wants to merge 4 commits intomui:nextfrom
Conversation
docs/public/_redirects
Outdated
| /r/toolpad-* https://mui-toolpad-docs.netlify.app/r/toolpad-:splat 200 | ||
|
|
||
| /* https://mui.com/:splat 301! | ||
| /* https://mui.com/:splat 302! |
|
Bundle size will be reported once CircleCI build #505624 finishes. |
| /x/* https://mui.com/x/:splat 302! | ||
| ## Unlike the store that expect to be hosted under a subfolder, | ||
| ## MUI X is configured to be hosted at the root. | ||
| /static/x/* https://docs-next--material-ui-x.netlify.app/static/x/:splat 200 |
There was a problem hiding this comment.
I guess we should remove this and the rest, since we redirect developers.
| /static/x/* https://docs-next--material-ui-x.netlify.app/static/x/:splat 200 |
There was a problem hiding this comment.
I want this change to be easily reversible - once we start working on v7, removing this redirect will be enough to host v7 docs under next.mui.com
docs/public/_redirects
Outdated
| /r/toolpad-* https://mui-toolpad-docs.netlify.app/r/toolpad-:splat 200 | ||
|
|
||
| /* https://mui.com/:splat 301! | ||
| /* https://mui.com/:splat 302! |
There was a problem hiding this comment.
This line is causing a side-effect - deploy previews from PRs are redirected to mui.com 🙃
See https://deploy-preview-36296--material-ui.netlify.app/
I guess the goal was to redirect next.mui.com/* => mui.com/*, so maybe to this instead?
| /* https://mui.com/:splat 302! | |
| https://next.mui.com/* https://mui.com/:splat 302! |
cc @m4theushw
There was a problem hiding this comment.
It's probably also the reason why test_e2e_website fails
There was a problem hiding this comment.
We actually have this exact redirect, just commented out on L11.
Maybe uncomment it and replace it with 302 while also removing this one? 🤔
|
Wouldn't be better to add a redirect in |
Yes, I think it's possible to redirect from Simplifying branches, subdomains, and redirects would be awesome! But I don't think I fully understand how it works right now, so there are high changes I'll break something without even knowing that 😅 |
Sync with mui#35686
|
@oliviertassinari @m4theushw @LukasTy Can you take a look again? Preview deployment from this branch seems to work - https://deploy-preview-36296--material-ui.netlify.app/x/react-data-grid/ redirects to mui.com |
| const anchor = page.locator('.DocSearch-Hits a:has-text("Card")'); | ||
|
|
||
| await expect(anchor.first()).toHaveAttribute('href', '/material-ui/react-card/#main-content'); | ||
| await expect(anchor.first()).toHaveAttribute('href', '/material-ui/react-card/'); |
|
@cherniavskii what's the status of this PR? |
We seem to have totally forgotten about it. 🙈 |
|
@LukasTy ah ok, I wasn't sure if it was forgotten or if the changes had already been made somewhere else potentially. Since it's 6 months old now I'll go ahead and close it, but we can always reopen it if it's needed. |
6 participants
Currently, MUI X v6 docs are available under https://next.mui.com/x/whats-new/
But once we release the v6 stable, we want to redirect to mui.com/x/* where the v6 stable docs will be deployed.