[docs][joy] Build TS versions for Menu component demos#36383
[docs][joy] Build TS versions for Menu component demos#36383hbjORbj merged 3 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-36383--material-ui.netlify.app/ Bundle size report |
hbjORbj
left a comment
hbjORbj
left a comment
There was a problem hiding this comment.
This PR includes changes to Typography demos. Please discard them.
hbjORbj
added
docs
hbjORbj
changed the title
|
Your branch includes commits that create typography TS demos and deletes them. You shouldn't have both commits in the first place. Please reset your branch to the latest master and only push commits related to Menu component demos. |
varunmulay22
force-pushed
the
menu-tsx-demos
branch
from
0ff2a19 to
b1b9ef7
Compare
| placement: 'right-start', | ||
| sx: { | ||
| width: 288, | ||
| [`& .${menuClasses.listbox}`]: { |
There was a problem hiding this comment.
Shouldn't be deleted. You can add these to the matching TS demo and run yarn docs:typescript:formatted.
There was a problem hiding this comment.
problem is menu classes does not have the listbox property
const menuClasses: MenuClasses = generateUtilityClasses('MuiMenu', [ 'root', 'expanded', 'colorPrimary', 'colorNeutral', 'colorDanger', 'colorInfo', 'colorSuccess', 'colorWarning', 'colorContext', 'variantPlain', 'variantOutlined', 'variantSoft', 'variantSolid', 'sizeSm', 'sizeMd', 'sizeLg', ]);
There was a problem hiding this comment.
You are right. I opened a new PR to address this issue. After I get a review from another team member on the PR, I will approve this one and merge it. Thanks.
github-actions
bot
added
the
PR: out-of-date
hbjORbj
left a comment
hbjORbj
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I rebased it and finalised it. Ready for merge!
github-actions
bot
removed
the
PR: out-of-date
| zIndex: 1000, | ||
| }); | ||
|
|
||
| export default function MenuListComposition(): JSX.Element { |
There was a problem hiding this comment.
Since it's for the docs, I think we should keep the type simpler, even if slower:
| export default function MenuListComposition(): JSX.Element { | |
| export default function MenuListComposition() { |
It's what the reset of the docs is doing, fixed in #38903.
4 participants
Menu Part of #36367