Skip to content

[TextField] Standardize onChange callback and remove valueLink #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alitaheri merged 1 commit into from
Mar 17, 2016
Merged

[TextField] Standardize onChange callback and remove valueLink #3699

alitaheri merged 1 commit into from
Mar 17, 2016

Conversation

@nathanmarks
Copy link
Contributor

@nathanmarks nathanmarks commented Mar 15, 2016

Adds the value as the 2nd callback argument for onChange and removes valueLink as per #2957 and #2880

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@nathanmarks
Copy link
Contributor Author

nathanmarks commented Mar 15, 2016

Force pushed a ninja change to my test... 😜

@nathanmarks nathanmarks added this to the 0.15.0 Release milestone Mar 16, 2016
@nathanmarks
Copy link
Contributor Author

nathanmarks commented Mar 16, 2016

FYI, I'm tending to EnhancedTextarea in another PR 👍

@alitaheri alitaheri mentioned this pull request Mar 16, 2016
Closed
14 tasks
@oliviertassinari oliviertassinari mentioned this pull request Mar 16, 2016
Closed
9 tasks
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 17, 2016

That looks good to me 👍.

@alitaheri
Copy link
Collaborator

alitaheri commented Mar 17, 2016

Ok I'll merge this. Hopefully people won't complain 😆 😆

alitaheri added a commit that referenced this pull request Mar 17, 2016
@alitaheri
Merge pull request #3699 from nathanmarks/textfield-updates
03f1f0b 
[TextField] Standardize onChange callback and remove valueLink
@alitaheri alitaheri merged commit 03f1f0b into mui:master Mar 17, 2016
@zannager zannager added the scope: text field Changes related to the text field. label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: text field Changes related to the text field.

Projects

None yet

Milestone

v0.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nathanmarks @oliviertassinari @alitaheri @zannager