Skip to content

[Autocomplete] add reason prop for resetInputValue of useAutocomplete#37013

Merged
mj12albert merged 17 commits intomui:masterfrom
binh1298:autocomplete-resetInputValue-reason
May 12, 2023
Merged

[Autocomplete] add reason prop for resetInputValue of useAutocomplete#37013
mj12albert merged 17 commits intomui:masterfrom
binh1298:autocomplete-resetInputValue-reason

Conversation

@binh1298
Copy link
Contributor

@binh1298 binh1298 commented Apr 25, 2023 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Apr 25, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37013--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against a6a6249

@binh1298 binh1298 changed the title feature: add reason prop for resetInputValue of useAutocomplete [Autocomplete] add reason prop for resetInputValue of useAutocomplete Apr 25, 2023
@binh1298 binh1298 mentioned this pull request Apr 25, 2023
Closed
2 tasks
binh1298
binh1298 commented Apr 25, 2023
View reviewed changes
@binh1298
Copy link
Contributor Author

binh1298 commented Apr 25, 2023

I am terribly sorry for the number of commits, it's my first time contributing and my vscode on ubuntu is really struggling rn 🙏

@zannager zannager added the scope: autocomplete Changes related to the autocomplete. This includes ComboBox. label Apr 25, 2023
@zannager zannager requested a review from michaldudak April 25, 2023 14:29
@mj12albert
Copy link
Member

mj12albert commented May 11, 2023

I am terribly sorry for the number of commits, it's my first time contributing and my vscode on ubuntu is really struggling rn 🙏

No worries, we squash when merging anyway, thanks for working on this 🙌

mj12albert
mj12albert approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mj12albert mj12albert merged commit a8ba538 into mui:master May 12, 2023
@ZeeshanTamboli ZeeshanTamboli added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label May 12, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented May 16, 2023

Is there a chance this could introduce a breaking change for developers that relied on testing reason === 'reset' but now the values are different?

@mj12albert mj12albert mentioned this pull request May 16, 2023
Merged
1 task
@siriwatknp
Copy link
Member

siriwatknp commented May 17, 2023 •
edited
Loading

Is there a chance this could introduce a breaking change for developers that relied on testing reason === 'reset' but now the values are different?

Can you be more specific? which case would be a breaking change? I'm reverting this one.

siriwatknp added a commit to siriwatknp/material-ui that referenced this pull request May 17, 2023
@siriwatknp
Revert "[Autocomplete] add reason prop for resetInputValue of useAuto…
42b8081 
…complete (mui#37013)"

This reverts commit a8ba538.
@siriwatknp siriwatknp mentioned this pull request May 17, 2023
Merged
1 task
siriwatknp added a commit that referenced this pull request May 17, 2023
@siriwatknp
Revert #37013 (#37295)
4bb4074
@binh1298
Copy link
Contributor Author

binh1298 commented May 17, 2023

hi @oliviertassinari @siriwatknp So does that mean that this will never get implemented in MUI 5 or is there anything I can do?

@mj12albert
Copy link
Member

mj12albert commented May 17, 2023 •
edited
Loading

@binh1298 Sorry I overlooked the breaking change – you can re-open another PR (and I'll label it as breaking change), it can be merged when we are ready to bump the minor version (5.13.x to 5.14.0)!

binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@siriwatknp @binh1298
Revert mui#37013 (mui#37295)
c39ee70
@binh1298 binh1298 mentioned this pull request May 17, 2023
Merged
1 task
@binh1298
Copy link
Contributor Author

binh1298 commented May 17, 2023 •
edited
Loading

hi @mj12albert , would you mind help me add the labels for this one? Thanks 🙏
#37301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mj12albert mj12albert mj12albert approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees

No one assigned

Labels

scope: autocomplete Changes related to the autocomplete. This includes ComboBox. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Autocomplete] Add an option to not resetInputValue on selectNewValue

7 participants

@binh1298 @mui-bot @mj12albert @oliviertassinari @siriwatknp @ZeeshanTamboli @zannager